-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gce] Ensure ressources are freed #17949
Open
clinique
wants to merge
11
commits into
openhab:main
Choose a base branch
from
clinique:gce_17940
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clinique
added
bug
An unexpected problem or unintended behavior of an add-on
work in progress
A PR that is not yet ready to be merged
labels
Dec 21, 2024
clinique
added
additional testing preferred
The change works for the pull request author. A test from someone else is preferred though.
and removed
work in progress
A PR that is not yet ready to be merged
labels
Dec 27, 2024
A bit of code revamp Signed-off-by: clinique <[email protected]>
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Some more code refactoring Signed-off-by: Gaël L'hopital <[email protected]> Signed-off-by: [email protected] <[email protected]>
Signed-off-by: clinique <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
additional testing preferred
The change works for the pull request author. A test from someone else is preferred though.
bug
An unexpected problem or unintended behavior of an add-on
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #17940
Global code review